Szabolcs Hubai

Results 40 issues of Szabolcs Hubai

See #71 for the details. Looks like an external tool is needed.

backend

There is an `AccessorBasedTypeAdapterFactory` (and it's annotations) at [`com.openseedbox.gson`](https://github.com/openseedbox/openseedbox-common/tree/480aa101dcf53297900e0b59452a58a89531a6b4/app/com/openseedbox/gson), which is used to customize Gson instances, like in [`Util.getGson()`](https://github.com/openseedbox/openseedbox-common/blob/480aa101dcf53297900e0b59452a58a89531a6b4/app/com/openseedbox/code/Util.java#L190): ```java public static Gson getGson() { return new GsonBuilder() .registerTypeAdapterFactory(new AccessorBasedTypeAdapterFactory())...

This change helps preventing * non-admin users to gain "control" (like stopping and restarting the Transmission backend) over backend nodes * unauthorized users to access the downloads

Current `User.hasExceededLimits` implementation [checks](https://github.com/openseedbox/openseedbox/blob/91e06c44842d8793a15a2d974325a2544f38943a/app/com/openseedbox/models/User.java#L50-L56) storage limits only. It would be nice to refactor `User.hasExceededLimits` to return a `CheckLimitsResult` object with `exceededStorage` and `exceededCount` boolean properties instead of a single boolean...

Avoid exposing backend url through [direct links](https://github.com/openseedbox/openseedbox/blob/91e06c44842d8793a15a2d974325a2544f38943a/app/views/tags/file-row.html#L11). The `` code is correct, linked above, but the `file.downloadLink` should point to the frontend itself.

I wasn't able to view the diff of commit a57585220f9dbd9265ad517a39961f5ac9bf75f3. Tapped to the line stats (+2, -2) and nothing happened. Opening the commit in browser showed that its a large...

procd is the new process management daemon and supports a [new style init script](https://openwrt.org/docs/guide-developer/procd-init-scripts).

After commit badaix/snapcast@0868ae1a6865be689c1568bc49ce6a26a1854cbc ("Remove debhelper files") it's unable to build Snapcast for OpenWrt. Those files arrived here in commit ~380d13c1595363cc39dae51fa54ba509c70dcff6~ 0a8e5b82437dfdcb51e3d2574259468a9dd94d88 ("Add debian package"). ~Do you have any schedule finishing...

``` docker run --rm -ti --pull always tomcat:10.1.0-jre11-temurin-jammy ``` VS ``` docker run --rm -ti --pull always tomcat:10.1.0-jre11-temurin-focal ``` ---- As previously noted (openseedbox/docker-base@0741bec61b8ce2430ac585d0a0cfad3184fc2de1), a downgrade to Focal Fossa was...

While building the Docker image the log is full of warnings about [unresolved variables](https://github.com/playframework/play1/blob/c2fc9ecab5affc223f202f0142e9f0dd2742f983/framework/src/play/Play.java#L407-L434). ``` Sep 04, 2022 6:07:58 PM play.Logger warn WARNING: Cannot replace APPLICATION_SECRET in configuration (application.secret=${APPLICATION_SECRET}) Sep...