cosmo

cosmo copied to clipboard

Fix issue where router update creates a new server and replaces the old server but doesn't start the new server listening Add config hot-reload to router when using a local config file (using the router update fix)

Motivation and Context

Fix corrects a mismatch between the documentation and implementation for router updating

Addition for hot-reload improves developer experience when running with a local config file

TODO

• [ ] Tests or benchmark included
• [ ] Documentation is changed or added on https://app.gitbook.com/
• [X] PR title must follow conventional-commit-standard

https://github.com/wundergraph/cosmo/issues/784

Hi @wainglaister,

Thanks so much for your contribution! I've updated the comments for the methods. Unfortunately, we can't merge the PR just yet. It needs tests, and the watcher functionality should be properly abstracted into a package. Given this, the priority of this feature is quite low at the moment, and we don't have the resources to guide you through these changes or to ensure that this feature is working as expected.

To prevent similar situations in the future, we recommend creating an issue first and reaching an agreement there. Additionally, it would have been beneficial to separate the documentation update from the file watcher implementation. Thank you!

This PR was marked stale due to lack of activity. It will be closed in 14 days.

As described earlier in comment. No action is left here.