Workbench icon indicating copy to clipboard operation
Workbench copied to clipboard

Update libraries to call `init` and specifiy dependency versions

Open sonnyp opened this issue 2 years ago • 5 comments

See https://github.com/sonnyp/Workbench/pull/736#discussion_r1376062117

Let's discuss what's best first

sonnyp avatar Oct 30 '23 11:10 sonnyp

One thing worth mentioning is that demos should sort of survive a sdk/platform bump because users can save them on their disk.

Maybe we specify all dependency versions in imports?

sonnyp avatar Nov 03 '23 22:11 sonnyp

Some thoughts of mine: https://github.com/sonnyp/Workbench/pull/732#discussion_r1382240886

[...] it's only required for libraries that have more than one version (Gtk, GtkSource, etc.) and it's recommended for Adw.

It's also not needed for direct dependencies of Gtk, such as Gdk. You can take Workbench itself as a reference for what needs versions: https://github.com/sonnyp/Workbench/blob/main/src/init.js#L1-L7

An additional thing: We should find out if Pango 1 is an implicit dependency of GTK, otherwise the release of Pango 2 could break things and we should also add Pango to the list.

theCapypara avatar Nov 03 '23 22:11 theCapypara

workbenchdev/demos#25 would also help here with identifying breaking changes when Sdk version is bumped. workbenchdev/demos#24 even more so.

theCapypara avatar Nov 03 '23 22:11 theCapypara

I think pango 1 is dependency for gtk 4 and pango 2 is gtk 5 material, but I'm not 100% sure.

UrtsiSantsi avatar Nov 03 '23 22:11 UrtsiSantsi

Related https://github.com/workbenchdev/Workbench/pull/879

sonnyp avatar Feb 11 '24 12:02 sonnyp