WordPress-iOS

WordPress-iOS copied to clipboard

Fixes #19229 Fixes #19228

This PR adds a blur effect to the prologue buttons, and extend the background gradient to the whole view

Related WordPressAuthenticator PR

https://user-images.githubusercontent.com/34376330/188240861-b7eddd87-fcc1-451b-9fc3-26a4ed8d46b2.mov

To test:

• checkout this branch and enable the newLandingScreen feature flag
• run rake dependencies to make sure the proper version of WordPressAuthenticator is pulled in
• Run the Jetpack target
• Log out if you're logged in
• Make sure the blur effect behind the buttons is visible. On iPad, it should extend along the whole width.

Regression Notes

1. Potential unintended areas of impact Prologue UI

2. What I did to test those areas of impact (or what existing automated tests I relied on) test prologue with feature flag enabled/disabled on both targets (Jetpack and WordPress)

3. What automated tests I added (or what prevented me from doing so) none PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding unit tests for my changes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19277-126fd9a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19277-126fd9a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Bumping to the next release, from 20.7 to 20.8, because neither this PR nor its authenticator counter part have been reviewed and I'm about to start the 20.7 code freeze.

👋 Hey @Gio2018! Would you mind getting this up to speed with trunk so we can compile it in Xcode 14? 🙇

👋 I originally left some comments in the WPAuthenticator PR when I meant to leave them here: [one] [two]

To recap, I saw that the scrolling words are interactive with VoiceOver, so we should disable that if they have a decorative role. Since that issue isn't related to this PR, I'll create a new issue for us to tackle. 👍 We can also do the same for colors / contrast if we determine that's an issue at all.

VoiceOver issue: https://github.com/wordpress-mobile/WordPress-iOS/issues/19327

LGTM @Gio2018 🚀

Can you remind me if we update this branch to point to the tagged beta once the WPAuthenticator PR is merged? I was thinking that's the case, but it's been a while. 😅

Yes: I just did that after publishing that beta.