WordPress-FluxC-Android

WordPress-FluxC-Android copied to clipboard

Adds: DB layer for remote feature flags

4

Parent Issue https://github.com/wordpress-mobile/WordPress-Android/issues/17050#event-7216422667 Parent PR - https://github.com/wordpress-mobile/WordPress-Android/pull/17101

AjeshRPai

NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParame...

6

Sentry Issue: [WOOCOMMERCE-ANDROID-4M2](https://sentry.io/organizations/a8c/issues/3494892312/?referrer=github_integration) ``` NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter at kotlin.text.StringsKt__StringsKt.startsWith at kotlin.text.StringsKt__StringsKt.startsWith$default(Strings.kt:835) at kotlin.text.StringsKt.startsWith$default at kotlin.text.StringsKt.startsWith$default at kotlin.text.StringsKt.startsWith$default ... (33 additional frame(s) were not...

sentry-io[bot]

As part of https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491 and [this change](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491/commits/3c13e594043c51cbb0f4dbeda5fefbc8d2434d11), [a discussion](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491#discussion_r943548751) was started as to whether the [PluginCoroutineStore](https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/e5cf7a211c05ac9c2051415b5221924918a0b589/fluxc/src/main/java/org/wordpress/android/fluxc/store/PluginCoroutineStore.kt#L35-L36) that was missing the @Singleton annotation should have it, just like the rest of...

ParaskP7

wzieba

As part of [this PR](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491) and [this change](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491/commits/3c13e594043c51cbb0f4dbeda5fefbc8d2434d11), [a discussion](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2491#discussion_r943548751) was started as to whether the [PluginCoroutineStore](https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/e5cf7a211c05ac9c2051415b5221924918a0b589/fluxc/src/main/java/org/wordpress/android/fluxc/store/PluginCoroutineStore.kt#L35-L36) that was missing the `@Singleton` annotation should have it, just like the rest...

ParaskP7

It's a performance improvement. For details, please see the internal post from @hichamboushaba : paqN3M-sT-p2 E.g. https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/7b079a021594107ec466b7aa015645eb23198af6/plugins/woocommerce/src/main/kotlin/org/wordpress/android/fluxc/store/WCOrderStore.kt#L755 should happen in a single transaction.

wzieba

In [this PR](https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2450#discussion_r915637632) it was noted that we assign search parameters in two places rather than reuse them. Digging further, it seems we should reuse `buildProductParametersMap` in `fetchProducts` because both...

nbradbury

This PR adds incremental annotation processing support by updating `com.google.auto.service:auto-service` & `wellsql` and adding the necessary `fluxc-processor/src/main/resources/META-INF/gradle/incremental.annotation.processors` file. The tricky bit for enabling incremental annotation processing is not the work...

oguzkocer

Batch update operations implemented in WCProductStore don't handle the [100-items API bulk update limit](https://woocommerce.github.io/woocommerce-rest-api-docs/#batch-update-products). This results in an error being returned from the backend in case the limit is exceeded....

samiuelson

We should revisit `toMap()` function (from `JsonExt.kt` file) and: - rename it to avoid confusion with the stdlib function of the same name - discuss usefulness - discuss performance impact...

wzieba