WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

JSApplicationIllegalArgumentException: Error while updating property 'alignItems' in shadow node of type: RCTView

Open AliSoftware opened this issue 3 years ago • 9 comments

Sentry Url: https://sentry.io/share/issue/0ecb07ab6b8d459e8b00fa099d87dfe9/ User Count: 187 Count: 208 First Release: 19.5-rc-2 First Seen: 2022-03-29T19:14:34.427000Z Last Seen: 2022-04-19T12:44:10Z 24 Hours: 18 30 Days: 208

JSApplicationIllegalArgumentException: Error while updating property 'alignItems' in shadow node of type: RCTView

...
(8 additional frame(s) were not displayed)

AliSoftware avatar Apr 19 '22 13:04 AliSoftware

I've analyzed several events related to this issue but I couldn't find a reliable pattern that leads to any clue about the culprit.

In a couple of cases, I saw two editor_session_start events triggered at the same time, which makes me think if this might be related to a case where users open two instances of the editor. In fact, I saw some comments about something similar in older issues also referencing the error JSApplicationIllegalArgumentException: Error while updating property X in shadow node of type: RCTView 🤔. In any case, I couldn't validate this theory as I'm unable to have two instances of the editor (I tried tapping very quickly on a post but doesn't open two instances).

I also tried using the post's content extracted from some of the user sessions, but still, I couldn't find a particular block that might be causing the error. I also tried using different themes but similarly, doesn't look related.

Additionally, per the Sentry events, I noticed that it's not unique to a property (in this case alignItems) but several of them, so it makes the issue even more random to be reproduced.

Screenshot 2022-04-20 at 17 45 21

I ran out of ideas in order to narrow down the cause, so, I'd appreciate it if someone else could take a look in case I'm overlooking anything, thanks 🙇 .

cc @geriux as has been involved in similar issues that are already addressed. I'm wondering if this might be another case related to themes and colors 🤔 , wdyt?

fluiddot avatar Apr 21 '22 14:04 fluiddot

Thank you for investigating this @fluiddot 🙇

I noticed that it's not unique to a property (in this case alignItems) but several of them, so it makes the issue even more random to be reproduced.

Indeed there are many occurrences of this exception 🤔

antonis avatar Apr 22 '22 08:04 antonis

cc @geriux as has been involved in similar issues that are already addressed. I'm wondering if this might be another case related to themes and colors 🤔 , wdyt?

I'll check it out to see if I find something, I'll report back 👍

geriux avatar Apr 22 '22 08:04 geriux

cc @geriux as has been involved in similar issues that are already addressed. I'm wondering if this might be another case related to themes and colors 🤔 , wdyt?

I don't think this one is related to the themes/colors.

I think this is more related to what you've mentioned about having more than one instance of the editor. I wonder though, why this is happening since 19.5.

I investigated a bit and it looks like this was addressed in the React native core codebase. And it's available in 0.68.

geriux avatar Apr 27 '22 10:04 geriux

I think this is more related to what you've mentioned about having more than one instance of the editor. I wonder though, why this is happening since 19.5.

Yep, I wonder the same 🤔.

I investigated a bit and it looks like this was addressed in the React native core codebase. And it's available in 0.68.

Good catch! Per the issue's description, it looks quite related to what we're experiencing. Let's see when we upgrade the React Native version if it no longer happens 🤞.

fluiddot avatar Apr 27 '22 14:04 fluiddot

Seems we're still on RN 0.66.2 in Gutenberg, thus my investigation into this issue stops here given that we're looking forward to see if an upgrade to React Native 0.68 or higher will fix this issue.

Currently based on my understanding the React Native upgrade is on hold, with other work being prioritized higher (internal ref: p9ugOq-34s-p2#comment-6225).

ovitrif avatar Aug 02 '22 11:08 ovitrif

Currently based on my understanding the React Native upgrade is on hold, with other work being prioritized higher

That's correct, hopefully we'll continue with the upgrade in the upcoming days 👍

geriux avatar Aug 03 '22 09:08 geriux

@geriux I see React Native was upgraded in this PR, do we expect the upgrade to fix the alignItems issue here?

thehenrybyrd avatar Dec 15 '22 09:12 thehenrybyrd

@geriux I see React Native was upgraded in this PR, do we expect the upgrade to fix the alignItems issue here?

I think it should fix the issue 😃 let's see once it ships if the Sentry issue reports start to go down.

geriux avatar Dec 15 '22 14:12 geriux