pytivo icon indicating copy to clipboard operation
pytivo copied to clipboard

Possible code error in plugins/video/video.py

Open itsayellow opened this issue 5 years ago • 1 comments

Lines 216-220:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth >= 1280)):
            data['showingBits'] = '4096'

I believe getTivoHeight and getTivoWidth should be function calls like so:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight(tsn) >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth(tsn) >= 1280)):
            data['showingBits'] = '4096'

itsayellow avatar Nov 26 '19 20:11 itsayellow

I'm adding another issue in video.py in this Issue because it's concerning the same file.

Line 456:

    def __delitem__(self):

should be:

    def __delitem__(self, key):

itsayellow avatar Nov 29 '19 04:11 itsayellow