scenefx icon indicating copy to clipboard operation
scenefx copied to clipboard

Fix some issues affecting compositor usage

Open WillPower3309 opened this issue 1 year ago • 2 comments

A few points from the scenefx patch notes on dwl:

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

NOTE: Blur doesn't work on windows with opacity set (opacity_active, opacity_inactive)

NOTE: In DWL's Makefile scenefx must be placed before wlroots, e.g. PKGS = scenefx wlroots wayland-server ...

WillPower3309 avatar Apr 20 '24 15:04 WillPower3309

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250 Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints BTW, DWL doesn't listen to size hints

Shadow off:

Shadow on:

wochap avatar Apr 21 '24 16:04 wochap

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250 Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints BTW, DWL doesn't listen to size hints

Shadow off:

Shadow on:

Does https://github.com/wlrfx/scenefx/pull/56 fix this? :)

WillPower3309 avatar Sep 11 '24 16:09 WillPower3309

Hi @WillPower3309, I’ve just tested DWL v0.8 with SceneFX from the latest commit in the main branch (b2e0ac4beb85aa89d0357dc8fcf8762808650890), and I can confirm that the following issue has been resolved:

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

wochap avatar Dec 25 '24 15:12 wochap

Hi @WillPower3309, I’ve just tested DWL v0.8 with SceneFX from the latest commit in the main branch (b2e0ac4beb85aa89d0357dc8fcf8762808650890), and I can confirm that the following issue has been resolved:

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Huge! Thank you very much

WillPower3309 avatar Dec 25 '24 15:12 WillPower3309

So I think the only bit left is covered in https://github.com/wlrfx/scenefx/issues/77, closing this one!

WillPower3309 avatar Feb 04 '25 22:02 WillPower3309