wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

chore: upgrade required node version to 18

Open atomrc opened this issue 1 year ago • 2 comments

Description

Will upgrade all our CI jobs to use node v18

Checklist

  • [x] PR has been self reviewed by the author;
  • [x] Hard-to-understand areas of the code have been commented;
  • [x] If it is a core feature, unit tests have been added;

atomrc avatar Jan 16 '24 13:01 atomrc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fb950ad) 45.43% compared to head (3c8f59e) 45.43%. Report is 90 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #16534   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files         740      740           
  Lines       24212    24212           
  Branches     5502     5502           
=======================================
  Hits        11000    11000           
  Misses      11800    11800           
  Partials     1412     1412

codecov[bot] avatar Jan 16 '24 13:01 codecov[bot]

fyi theres a small chance this breaks elastic beanstalk. unfortunately webapp is running on node 16 there.

tlebon avatar Jan 17 '24 15:01 tlebon