wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat: fix the icon size in conversation list - ACC - 263

Open BrzozowskiPawel opened this issue 3 years ago • 2 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fix the icon in the top right corner that directs to the settings.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

BrzozowskiPawel avatar Sep 20 '22 14:09 BrzozowskiPawel

This PR is not ready to be checked yet. I need to discuss a couple of things before final changes.

BrzozowskiPawel avatar Sep 20 '22 16:09 BrzozowskiPawel

Codecov Report

Merging #5864 (e49c0ae) into develop (18c52de) will decrease coverage by 0.00%. The diff coverage is 80.00%.

:exclamation: Current head e49c0ae differs from pull request most recent head 3c4df3a. Consider uploading reports for the commit 3c4df3a to get more accurate results

@@             Coverage Diff             @@
##           develop    #5864      +/-   ##
===========================================
- Coverage    60.60%   60.60%   -0.01%     
===========================================
  Files         1026     1026              
  Lines        57064    57066       +2     
  Branches     23689    23689              
===========================================
+ Hits         34582    34583       +1     
- Misses       22106    22107       +1     
  Partials       376      376              

codecov-commenter avatar Sep 21 '22 10:09 codecov-commenter

@BrzozowskiPawel Could you add more description what kind of the changes are in this PR?

KaterinaWire avatar Sep 23 '22 12:09 KaterinaWire

After some chatting with Anette and Rahil they asked me to change functionality a bit so I will make it a draft again.

BrzozowskiPawel avatar Sep 26 '22 07:09 BrzozowskiPawel

@KaterinaWire @agisilaos Fixed.

BrzozowskiPawel avatar Sep 26 '22 09:09 BrzozowskiPawel

To be clear:

  • the "border" is now visible always.
  • the dot icon indicates an unread message only for the account that has an unread message.

BrzozowskiPawel avatar Sep 26 '22 10:09 BrzozowskiPawel