wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat(mls): add protocol details to group options FS-880

Open johnxnguyen opened this issue 3 years ago • 1 comments

TaskFS-880 [IOS] Protocol and Cyphersuite indication in the Group properties


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR adds the UI to show the message protocol details for the conversation:

Simulator Screen Shot - Sim 3 - 2022-09-19 at 23 01 06


PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

johnxnguyen avatar Sep 19 '22 21:09 johnxnguyen

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 19 '22 21:09 CLAassistant

Codecov Report

Merging #5863 (66ae0ac) into feat/mls (6d4ea12) will decrease coverage by 0.93%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           feat/mls    #5863      +/-   ##
============================================
- Coverage     60.32%   59.38%   -0.94%     
============================================
  Files          1015     1034      +19     
  Lines         56766    58315    +1549     
  Branches      23690    24215     +525     
============================================
+ Hits          34244    34632     +388     
- Misses        22153    23307    +1154     
- Partials        369      376       +7     

codecov-commenter avatar Sep 23 '22 07:09 codecov-commenter