wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat: simple-nse-test SQSERVICES-1700

Open MarcinR opened this issue 3 years ago • 2 comments

SubtaskSQSERVICES-1700 Refactor NotificationService for possible reuse

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

MarcinR avatar Sep 07 '22 07:09 MarcinR

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: MarcinR
:x: johnxnguyen
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 21 '22 09:09 CLAassistant

Codecov Report

:exclamation: No coverage uploaded for pull request base (feat/simple-nse@d0c91f4). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 37000db differs from pull request most recent head b5f7197. Consider uploading reports for the commit b5f7197 to get more accurate results

@@                Coverage Diff                 @@
##             feat/simple-nse    #5840   +/-   ##
==================================================
  Coverage                   ?   60.58%           
==================================================
  Files                      ?     1026           
  Lines                      ?    57076           
  Branches                   ?    23699           
==================================================
  Hits                       ?    34582           
  Misses                     ?    22118           
  Partials                   ?      376           

codecov-commenter avatar Sep 21 '22 10:09 codecov-commenter