wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat: fix contrast issue with the no message in conversation search - ACC - 240

Open BrzozowskiPawel opened this issue 3 years ago • 5 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

In this PR I have been working on the no message in conversation search. But after discussion with the design team, there were design problems with cells (it's started to blend in with the background). Because of that, I needed to change the color and other properties of also the cells (this is why this PR HAVE TO BE THAT BIG).

Test Coverage (Optional)

  • [x] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

BrzozowskiPawel avatar Aug 31 '22 10:08 BrzozowskiPawel

Codecov Report

Merging #5827 (9b0e4fa) into develop (560ab15) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5827      +/-   ##
===========================================
+ Coverage    60.58%   60.60%   +0.01%     
===========================================
  Files         1026     1026              
  Lines        57048    57055       +7     
  Branches     23686    23685       -1     
===========================================
+ Hits         34564    34576      +12     
+ Misses       22108    22103       -5     
  Partials       376      376              

codecov-commenter avatar Aug 31 '22 10:08 codecov-commenter

@agisilaos I will fix these snapshots. image I was not sure about it as it's was other screen but that's not a problem, it will be fixed in a while.

BrzozowskiPawel avatar Sep 06 '22 08:09 BrzozowskiPawel

Screenshot 2022-09-06 at 12 26 12 @BrzozowskiPawel They have different cornerRadius

KaterinaWire avatar Sep 06 '22 10:09 KaterinaWire

@BrzozowskiPawel Is this ready for another round of reviews?

agisilaos avatar Sep 12 '22 07:09 agisilaos

@agisilaos yes. As we discussed the I have changed the UI but no spaces between cells.

BrzozowskiPawel avatar Sep 12 '22 07:09 BrzozowskiPawel