wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat: fix contrast issue with the no message message in conversation search - ACC - 240

Open BrzozowskiPawel opened this issue 3 years ago • 1 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fix the appearance of the screen when there are no messages found in the conversation search.

Issues

The current appearance is outdated.

Solutions

Changed color to new according to the Figma design.

Test Coverage (Optional)

  • [x] I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

BrzozowskiPawel avatar Aug 08 '22 10:08 BrzozowskiPawel

Codecov Report

Merging #5797 (a2461aa) into develop (7d4aba4) will increase coverage by 0.00%. The diff coverage is 91.42%.

:exclamation: Current head a2461aa differs from pull request most recent head 94be371. Consider uploading reports for the commit 94be371 to get more accurate results

@@           Coverage Diff            @@
##           develop    #5797   +/-   ##
========================================
  Coverage    60.50%   60.51%           
========================================
  Files         1019     1018    -1     
  Lines        56715    56734   +19     
  Branches     23577    23575    -2     
========================================
+ Hits         34318    34333   +15     
- Misses       22025    22029    +4     
  Partials       372      372           

codecov-commenter avatar Aug 09 '22 12:08 codecov-commenter