wire-ios_legacy
wire-ios_legacy copied to clipboard
feat: apply new colors in conversations list [BOTTOM TAB BAR] - ACC-226
|
|
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764 - [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Updated the appearance of the tab bar according to the figma.
Needs releases with:
This PR is a second part of the conversation list PR. Needs to be merged after the first part.
- [x] GitHub link to other pull request
Testing
Test Coverage (Optional)
- [x] I have added automated test to this contribution
PR Post Submission Checklist for internal contributors (Optional)
- [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Codecov Report
Merging #5796 (71dca71) into feature/apply-new-colors-in-conversations-list (ce14d37) will increase coverage by
0.00%. The diff coverage is91.80%.
:exclamation: Current head 71dca71 differs from pull request most recent head 3d8272c. Consider uploading reports for the commit 3d8272c to get more accurate results
@@ Coverage Diff @@
## feature/apply-new-colors-in-conversations-list #5796 +/- ##
================================================================================
Coverage 60.54% 60.55%
================================================================================
Files 1017 1019 +2
Lines 56702 56813 +111
Branches 23539 23577 +38
================================================================================
+ Hits 34333 34405 +72
- Misses 21997 22035 +38
- Partials 372 373 +1
This PR was closed as I was very outdated and most of the code was either not related to the topic or fixed somewhere else.