wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

feat: apply new colors in settings screen- ACC-225

Open BrzozowskiPawel opened this issue 3 years ago • 4 comments

SubtaskACC-225 [iOS] Apply new colors in Settings Screen


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated color for the new Figma design in the settings screen.

Issues

The colors and design were outdated.

Solutions

Changing the properties to match the new design.

Test Coverage (Optional)

  • [x] I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

BrzozowskiPawel avatar Jul 28 '22 10:07 BrzozowskiPawel

Codecov Report

Merging #5790 (bdd5e23) into develop (7d4aba4) will decrease coverage by 0.02%. The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           develop    #5790      +/-   ##
===========================================
- Coverage    60.50%   60.48%   -0.03%     
===========================================
  Files         1019     1020       +1     
  Lines        56715    56658      -57     
  Branches     23577    23551      -26     
===========================================
- Hits         34318    34270      -48     
+ Misses       22025    22015      -10     
- Partials       372      373       +1     

codecov-commenter avatar Aug 01 '22 11:08 codecov-commenter

@BrzozowskiPawel I saw in ConversationOptionsViewControllerTests that only a few cells have separators? Is it correct?

KaterinaWire avatar Aug 02 '22 15:08 KaterinaWire

@BrzozowskiPawel @agisilaos Shouldn't the cells in ClientListViewControllerTests have a white background in the light mode?

KaterinaWire avatar Aug 02 '22 15:08 KaterinaWire

@KaterinaWire

  1. Yes there was an issue. Other cells should have also different UI. This was a screen that is entered thru messages. Besides of that somehow I was not able to have this sharing link on the simulator but I am fixing it already.
  2. Yes this is also a valid case. I could not find this cell inside the fimga's preferences or conversation but I have finally found it and applied new design.

BrzozowskiPawel avatar Aug 02 '22 17:08 BrzozowskiPawel

Requested changes applied.

BrzozowskiPawel avatar Aug 11 '22 12:08 BrzozowskiPawel