wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

fix: Snapshot Tests related to new colors in Start Conversation View [Part 2] AC-220

Open agisilaos opened this issue 3 years ago • 1 comments

PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³

  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

With this PR we fix part of the snapshot test failures introduced with the changes we made in https://github.com/wireapp/wire-ios/pull/5782. More PR's to come.

#5782, #5785 needs to be reviewed first.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

agisilaos avatar Jul 25 '22 14:07 agisilaos

@agisilaos GroupDetailsViewControllerSnapshotTests in light mode have different background colors

KaterinaWire avatar Jul 27 '22 14:07 KaterinaWire

Closing this because #5798 is now merged.

agisilaos avatar Aug 11 '22 07:08 agisilaos