wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

fix: Improve contrast by changing the colors in Start New Conversation View ACC - 220

Open agisilaos opened this issue 3 years ago • 0 comments

PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³

  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

With this PR we update the colors in the Start Conversation View. I've made a couple of changes and in places where I could, I removed the color scheme variant entirely. Slowly but surely we're not going to be dependent on that for our colors in the app.

Note: There are a lot of test failures. I'm going to fix them in separate PR's and then merge those PR's in this branch fix/start-conversation-view-updated-two. So I think it would be best to review this PR first and then I'm going to start opening the PR's for the test fixes.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

agisilaos avatar Jul 22 '22 07:07 agisilaos

Closing this because #5798 is now merged.

agisilaos avatar Aug 11 '22 07:08 agisilaos