wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

fix: Color contrast issues in conversation view ACC - 168

Open agisilaos opened this issue 3 years ago • 3 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

With this PR we fix color contrast issues in the Conversation View.

TO-DO:

  • [ ] Fix tests when #5723 is merged

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

agisilaos avatar Jun 22 '22 11:06 agisilaos

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 04 '22 16:07 CLAassistant

Codecov Report

Merging #5732 (67195d5) into develop (c8435c5) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5732   +/-   ##
========================================
  Coverage    60.51%   60.51%           
========================================
  Files         1020     1020           
  Lines        56726    56726           
  Branches     23584    23584           
========================================
+ Hits         34325    34327    +2     
+ Misses       22029    22027    -2     
  Partials       372      372           

codecov-commenter avatar Jul 04 '22 16:07 codecov-commenter

@johnxnguyen Just deleted it. Most likely from a merge conflict.

agisilaos avatar Jul 05 '22 09:07 agisilaos