wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

fix: make use of L10n enum - IC-57

Open BrzozowskiPawel opened this issue 3 years ago • 3 comments

TaskIC-57 Make use of L10n enum


PR Submission Checklist for internal contributors

  • The PR Title
    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³

What's new in this PR?

Replacement .localized to l10n.

Issues

Use l10n to make strings localizable.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

BrzozowskiPawel avatar Jun 08 '22 15:06 BrzozowskiPawel

Codecov Report

Merging #5705 (5e5b0ea) into develop (6ece083) will increase coverage by 0.21%. The diff coverage is 55.54%.

:exclamation: Current head 5e5b0ea differs from pull request most recent head ee46b05. Consider uploading reports for the commit ee46b05 to get more accurate results

@@             Coverage Diff             @@
##           develop    #5705      +/-   ##
===========================================
+ Coverage    60.52%   60.73%   +0.21%     
===========================================
  Files         1018     1013       -5     
  Lines        56724    57064     +340     
  Branches     23576    23720     +144     
===========================================
+ Hits         34331    34659     +328     
- Misses       22021    22034      +13     
+ Partials       372      371       -1     

codecov-commenter avatar Jun 12 '22 11:06 codecov-commenter

Ok, I have resolved all the CI issues. It should be good now.

BrzozowskiPawel avatar Jun 12 '22 11:06 BrzozowskiPawel

@agisilaos after the merge there were issues. I have fixed it but with the merge there were some changes. Please take a look on 2 last commits once again to make sure that I did everything ok.

BrzozowskiPawel avatar Aug 08 '22 12:08 BrzozowskiPawel