wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

fix: color of the navigation bar for the ChangeHandleViewController IC-56

Open agisilaos opened this issue 3 years ago • 2 comments

TaskIC-56 The color of the ChangeHandleViewController is transparent instead of black


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

With this PR we fix the color of the navigation bar from transparent to black.

BEFORE AFTER
Screenshot 2022-06-03 at 10 53 06 Screenshot 2022-06-03 at 13 31 20

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

agisilaos avatar Jun 03 '22 11:06 agisilaos

Code looks good to me 👍

BrzozowskiPawel avatar Jun 03 '22 13:06 BrzozowskiPawel

Codecov Report

Merging #5697 (70dae8c) into develop (7d4aba4) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5697   +/-   ##
========================================
  Coverage    60.50%   60.51%           
========================================
  Files         1019     1019           
  Lines        56715    56716    +1     
  Branches     23577    23577           
========================================
+ Hits         34318    34324    +6     
+ Misses       22025    22020    -5     
  Partials       372      372           

codecov-commenter avatar Jun 07 '22 10:06 codecov-commenter