acts_as_archive icon indicating copy to clipboard operation
acts_as_archive copied to clipboard

Fix for Issue 24, polymorphic association

Open elmatou opened this issue 15 years ago • 6 comments

Hi Winton, here is a fix for the polymorphic association issue. The point is to check the kind of association (polymorphic and dependent) before calling ReflexionAssociation#klass

elmatou avatar Mar 15 '11 09:03 elmatou

The only problem is the repo owner doesn't maintain anymore this gem.

elmatou avatar Jun 15 '11 06:06 elmatou

@elmatou Do you have any interest in taking over ownership of ActsAsArchive?

winton avatar Jan 10 '12 04:01 winton

Hi @winton, I'm not sure to be the best to maintain ActsAsArchive as it relies on others of your gems, and as I'm less on github than before. But I would be glad to fix the little issues we found in the library.

I suggest, you keep the ownership, and add me as a maintener on github and rubygems, and I will push important fixes.

If you are not comfortable with this solution, maybe can you just accept a Pull Request for the two main issues (polymorphic + loading) and then release a new and last version of your gem.

See you

elmatou avatar Jan 12 '12 09:01 elmatou

Would it perhaps be a good idea to put a big bold note in the readme that it is unmaintained?

knzai avatar Jan 07 '13 18:01 knzai

Added @elmatou to collaborators and added a note about the project not being maintained.

winton avatar Jan 07 '13 20:01 winton

Thanks winton. I'll see if the client that is using it is willing to be the official maintainer or not.

knzai avatar Jan 07 '13 20:01 knzai