fullscreen icon indicating copy to clipboard operation
fullscreen copied to clipboard

Should browser UI be able to activate fullscreen even if iframe is missing allowfullscreen

Open smaug---- opened this issue 9 years ago • 6 comments

...and if so, should fullscreenchange event fire? https://bugzilla.mozilla.org/show_bug.cgi?id=1302976#c8 (I think xidorn didn't mean sandboxed document but iframe without allowfullscreen)

smaug---- avatar Sep 20 '16 12:09 smaug----

@rniwa @teddink @foolip

smaug---- avatar Sep 20 '16 12:09 smaug----

Blink used to have an exemption for video.webkitEnterFullscreen which included native video controls, but I managed to removed it: https://codereview.chromium.org/1237133002 https://codereview.chromium.org/1240573005

foolip avatar Sep 20 '16 14:09 foolip

sure, but this is about browser UI stuff, like context menu or default UI for video element and such.

smaug---- avatar Sep 20 '16 23:09 smaug----

That is what I'm talking about too, the change "included native video controls." The context menu for video doesn't allow going fullscreen.

foolip avatar Sep 21 '16 08:09 foolip

Currently Edge and Safari allow user to enter fullscreen regardless of whether it is allowed by DOM. Firefox is... something in-between, which doesn't make much sense. We want to align to one or the other.

I personally think disallowing it even via browser UI is safer (less troublesome), while @smaug---- thinks we should allow user to do what they want.

upsuper avatar Sep 25 '16 08:09 upsuper

The specification can encourage one way or another, but we can't require anything here I think, although I guess we should say what happens with respect to events if an implementation allows it.

annevk avatar Sep 26 '16 14:09 annevk