forgit icon indicating copy to clipboard operation
forgit copied to clipboard

[Fish] ga/gd no longer works after plugin upgrade

Open ray-x opened this issue 3 years ago • 3 comments

Check list

  • [X] I have read through the README
  • [X] I have the latest version of forgit
  • [X] I have searched through the existing issues

Environment info

  • OS
    • [X] Linux
    • [ ] Mac OS X
    • [ ] Windows
    • [ ] Others:
  • Shell
    • [ ] bash
    • [ ] zsh
    • [X] fish

Problem / Steps to reproduce

in a git repo, run ga or gd The script complains about forgit::extract_file not found/syntax error.

image

Update: my $SHELL is set to bash, but my current shell is fish, set $SHELL to fish works fine. Similar to this https://github.com/wfxr/forgit/issues/168

ray-x avatar Jul 28 '22 17:07 ray-x

hmm, this is interesting.

Is there a reason that your $SHELL is bash instead of fish?

See also this ticket: https://github.com/wfxr/forgit/pull/169

There was a fix for it then, but it broke mine when my $SHELL was fish...

cjappl avatar Jul 28 '22 18:07 cjappl

I'm not sure there is a long term solution that will fix both, as fish syntax is very different than bash syntax, and we rely on fish scripting internally to have it work properly

cjappl avatar Jul 28 '22 18:07 cjappl

If login shell is fish, I think it should be OK. But if you switch between shells, might be an issue.

ray-x avatar Jul 28 '22 23:07 ray-x

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 28 '22 01:09 stale[bot]

as there is a workaround, close it for now.

ray-x avatar Sep 28 '22 10:09 ray-x