viem icon indicating copy to clipboard operation
viem copied to clipboard

Remove CIP-42 support

Open shazarre opened this issue 1 year ago • 3 comments

This PR removes deprecated CIP-42 transaction type support for Celo in favour of CIP-64.

It still keeps functionality to parse and format existing CIP-42 transactions that can be retrieved directly from the blockchain.


PR-Codex overview

This PR removes support for CIP-42 and treats all transactions with a feeCurrency field as CIP-64.

Detailed summary

  • Removed CIP-42 support
  • Transactions with feeCurrency are treated as CIP-64
  • Updated transaction types and formatters

The following files were skipped due to too many changes: src/celo/types.ts, src/celo/parsers.test.ts, src/celo/getTransaction.test.ts, src/celo/formatters.test.ts, src/celo/serializers.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

shazarre avatar Apr 26 '24 08:04 shazarre

🦋 Changeset detected

Latest commit: baa511675586ebd60bcd7880f3c5d4f4c91106ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 26 '24 08:04 changeset-bot[bot]

@shazarre is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 26 '24 08:04 vercel[bot]

for more context CIP42 has been deprecated since gingerbreadhardfork and transactions sent to blockchain using this format will not be executed in following hardfork.

aaronmgdr avatar Apr 26 '24 13:04 aaronmgdr

Superseded by #2277.

jxom avatar May 19 '24 20:05 jxom