Evan Weinberg

Results 61 comments of Evan Weinberg
trafficstars

Thank you for the contribution @detar ! I just pushed a quick `clang-format`, and I'll do my own cursory test before approving, but this should be good to go.

@detar I just ran a quick `ks_spectrum` workflow, replacing `no_gauge_fix` with `coulomb_gauge_fix`, and got the following error: ``` Fixing to Coulomb gauge Starting Coulomb gauge fixing... Overrelaxation boost parameter: 1.800000e+00...

Ah, here's the issue, the function you added to `quda.h` is already declared in `quda_milc_interface.h`: ``` $ grep -r "qudaGaugeFixingOVR" * include/quda_milc_interface.h: void qudaGaugeFixingOVR( const int precision, include/quda.h: void qudaGaugeFixingOVR(int...

@detar I just made some changes to your branch, as well as the corresponding changes in MILC in the `develop` branch of https://github.com/lattice/milc_qcd ; I made a PR here for...

@maddyscientist this is ready for your review, it passed various tests on my end. Since I had a heavy hand in taking the PR an extra mile I don't see...

> @weinbe2 is there a simple test on the MILC side that can be used to verify this PR (e.g., for myself to run as part of this review)? I...

We should use all caps specifically to designate the preprocessor definition. I'd be receptive to something like `quda::parallel` as well but I don't think we can namespace defines like that?...

@cpviolator just catching up a little and making absolute sure, you're seeing _divergence_, not stalling, correct? I see stalling constantly for HISQ, and it's never an issue (in fact, in...