pull icon indicating copy to clipboard operation
pull copied to clipboard

Published 20 hours ago • verified publisher icon wei

Label not creating when upsteam branch updates more than once within [Pull]PR opened period

Open michaeljin89757 opened this issue 3 years ago • 2 comments

image https://github.com/michaeljin89757/BoTest/pull/3

image https://github.com/michaeljin89757/BoTest/pull/2

As shown in pictures above, when there are updates happened within [Pull]PR opened period the pull bot did not create the pull label as expected.

michaeljin89757 avatar May 23 '22 04:05 michaeljin89757

Hi @michaeljin89757 thanks for the report!

The label should have been added as soon as the PR is created.

In the PR you shared, we can see that this update snippet did not work because the PR body was not updated and the tag also not added: https://github.com/wei/pull/blob/f5d246c69bfaf4a80d202b48f099120bcd6570be/lib/pull.js#L198-L205

The only thing I can think of is GitHub taking its time to calculate mergability state and causing updates to the PR to fail. I need to step through and see if this is the case and report to GitHub. Thanks again!

If anyone can help reproduce this with maybe a couple curls, that would help me tremendously!

wei avatar May 25 '22 16:05 wei

The only thing I can think of is GitHub taking its time to calculate mergability state and causing updates to the PR to fail. Or it's not creating PR and not processing the rest of the commands

Drez4754 avatar Dec 03 '22 21:12 Drez4754