voting-app icon indicating copy to clipboard operation
voting-app copied to clipboard

chore: update dependencies

Open anikethsaha opened this issue 5 years ago • 7 comments

this PR contains

  • update babel packages to @babel/*
  • removed un-necessary babel plugin for spread operation of objects

No changes in source code and the site is working fine with no changes

anikethsaha avatar Mar 18 '20 16:03 anikethsaha

getting this

image

while running in yarn start for es6 style webpack config.

I am using node 10

anikethsaha avatar Mar 18 '20 17:03 anikethsaha

Why is this change from npm to yarn necessary?

montogeek avatar Mar 19 '20 07:03 montogeek

The main docs site is using yarn as well. so I thought of keeping it consistent ! do you want this in npm ?

anikethsaha avatar Mar 19 '20 07:03 anikethsaha

Lets not, this is separate package with many differences from docs repo

EugeneHlushko avatar Apr 06 '20 15:04 EugeneHlushko

cc @montogeek @evilebottnawi @EugeneHlushko Let me know if the current changes are fine.

anikethsaha avatar Apr 11 '20 16:04 anikethsaha

The new bundle is much bigger, i dont think its fine

EugeneHlushko avatar Apr 14 '20 07:04 EugeneHlushko

may be because of whatwg-fetch.

anikethsaha avatar Apr 14 '20 07:04 anikethsaha