webmin icon indicating copy to clipboard operation
webmin copied to clipboard

problem handlyng old versions of certbot 1.11

Open Netmees opened this issue 1 year ago • 1 comments

you have a problem handlyng old versions of certbot with --no-renew-keys no handled by old versions of certbot (1.11) on webmin i have to comment on webmin/letsencrypt-lib.pl #else { #$reuse_flags = " --no-reuse-key"; #} for certbot to work…

Netmees avatar Apr 26 '24 10:04 Netmees

Hello,

Thanks for the heads up!

What OS is this?

iliaross avatar Apr 26 '24 10:04 iliaross

it`s redhat fork, still not solved in new releases... i had to change once again after upgrade... its important to remove this old call to --no-reuse-key

Netmees avatar Aug 15 '24 09:08 Netmees

@iliaross I think I mentioned this is another ticket? Do we really need to set that flag at all if --no-reuse-key is the default?

jcameron avatar Aug 15 '24 09:08 jcameron

Do we really need to set that flag at all if --no-reuse-key is the default?

Yes, I clearly remember that it was needed. Things went broken without it.

Though, we need to test if it's supported. Here is the patch https://github.com/webmin/webmin/commit/cf838e5d9ad6a173d12992c8de77e90b1c0ad7c9.

iliaross avatar Aug 15 '24 10:08 iliaross

--no-reuse-key its not recogniced ( its removed in new versions) and produce an error that stops generating the certificate

Netmees avatar Aug 15 '24 11:08 Netmees

--no-reuse-key its not recogniced ( its removed in new versions) and produce an error that stops generating the certificate

I'm a bit confused! What's the output of certbot --version on your system? Also, what OS are you running?

Can you apply the latest patch and see if it solves the problem for you?

webmin patch https://github.com/webmin/webmin/commit/cf838e5d

iliaross avatar Aug 15 '24 12:08 iliaross