fix(new-metrics): add TypeError
This pull request addresses
Right now, if a client metric event contains a TypeError error, it gets classified as 'BrowserMediaError' because TypeError is one of the possible error that can result from MediaDevices: getUserMedia() method (https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia#aborterror:~:text=individual%20user%20agent.-,TypeError,-Thrown%20if%20the)
by making the following changes
That assumption is wrong, as any service can return a TypeError and, unfortunately, we do not have a way of identifying the service this error comes from. So this PR classifies it as a TypeError of category 'other'.
Change Type
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation update
- [ ] Tooling change
- [ ] Internal code refactor
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
-
[X] I have read and followed contributing guidelines
-
[X] I discussed changes with code owners prior to submitting this pull request
-
[X] I have not skipped any automated checks
-
[X] All existing and new tests passed
-
[X] I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-3527.d3m3l2kee0btzx.amplifyapp.com
We are no longer accepting PRs on beta @nataliadelmar . Do we still need this PR? If not, can you please close this?