wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Published 20 hours ago • verified publisher icon web-platform-tests

WPT logo: differences in size between with-background and without-background

Open zcorpan opened this issue 6 years ago • 16 comments

https://github.com/web-platform-tests/wpt/tree/master/images/wpt-logo

The ones with a background have spacing around the logo, but the ones with transparent background do not. This makes them not so interchangeable. (This is probably my fault.)

Should we make this consistent? cc @foolip @gsnedders @isaacdurazo

zcorpan avatar Sep 26 '19 12:09 zcorpan

Yes please :)

Also we can delete the orange one if we don't plan to use it anywhere.

foolip avatar Sep 26 '19 13:09 foolip

The background color is not intended to be "part" of the logo, it just shows us how it looks in such context. We included a file without background so you could maybe add the background color using CSS, and we have a file with the background color so we know how to use it and how it would look.

isaacdurazo avatar Sep 26 '19 17:09 isaacdurazo

Hi, I would like to work on this issue, Can I get started with this?

prsmahajan avatar Jun 08 '21 07:06 prsmahajan

@prsmahajan absolutely, feel free to send a PR for it. Do you know where to start, which files to change and all?

foolip avatar Jun 08 '21 10:06 foolip

I want to know, what's the problem you're facing and where to start from?

prsmahajan avatar Jun 08 '21 10:06 prsmahajan

@prsmahajan if you take a look at https://raw.githubusercontent.com/web-platform-tests/wpt/master/images/wpt-logo/wpt-logo-darkblue-bg.svg and https://raw.githubusercontent.com/web-platform-tests/wpt/master/images/wpt-logo/wpt-logo-darkblue.svg side-by-side you'll notice the shapes aren't aligned.

Fixing this would be a matter of making sure that the path data in both files use the same numbers and that the only difference between them is the colors.

foolip avatar Jun 08 '21 10:06 foolip

Do you want to change the color or the size of the svg icon?

prsmahajan avatar Jun 09 '21 06:06 prsmahajan

@prsmahajan we'd want to keep the colors of each icon as they are, but make the sizes consistent between them all, so that if one replaces one with another, the "WPT" symbol is in exactly the same place.

foolip avatar Jun 09 '21 07:06 foolip

In which of the directories are the svg logo located?

prsmahajan avatar Jun 09 '21 08:06 prsmahajan

They're in https://github.com/web-platform-tests/wpt/tree/master/images/wpt-logo

foolip avatar Jun 09 '21 08:06 foolip

Where are the images being used?

prsmahajan avatar Jun 09 '21 08:06 prsmahajan

The issue is already solved senior, there's no issue in size!

prsmahajan avatar Jun 09 '21 08:06 prsmahajan

@prsmahajan, thanks, I've asked @zcorpan to review https://github.com/web-platform-tests/wpt/pull/29305.

foolip avatar Jun 09 '21 09:06 foolip

Thansk @foolip

prsmahajan avatar Jun 09 '21 09:06 prsmahajan

Is there any issues for me?

prsmahajan avatar Jun 09 '21 09:06 prsmahajan

Can @foolip can I solve this issue?

GAURAV1-ui avatar Jul 21 '22 00:07 GAURAV1-ui

hey can i solve this issue?

ijishnupr avatar Aug 23 '23 12:08 ijishnupr

No need to ask, just submit a PR. See https://github.com/web-platform-tests/wpt/pull/29305#issuecomment-858030708 for guidance. Thanks!

zcorpan avatar Aug 31 '23 09:08 zcorpan