wpt-pr-bot
wpt-pr-bot copied to clipboard
web-platform-tests
If a reviewer has previously unassigned the review, don't reassign it to them
#51 started automatically assigning issues to reviewers.
Some directories are a bit large, and some reviewers might not feel comfortable reviewing everything.
As a first rough approximation, if the issue has previously been assigned to [X] we should assign it to [X] to review.
Note this isn't perfect, because we might also want to unassign PRs if someone is travelling, for example.
Good idea. This can be determined from the PR itself and doesn't require storing state in wpt-pr-bot.
Can you file a separate issue for vacation logic if you have a proposed fix?
Can you file a separate issue for vacation logic if you have a proposed fix?
I don't, sadly. That I believe is a much harder problem, esp. given it seems unlikely that orgs will be willing to expose any vacation data they have for their employees (and that doesn't work for people not in those orgs).
More generally, I think the bot should only assign once per PR. If I unassign the person the bot had assigned, it's annoying for the bot to automatically assign somebody else. (e.g. https://github.com/web-platform-tests/wpt/pull/14703 )
