yalc icon indicating copy to clipboard operation
yalc copied to clipboard

Yalc package includes node_modules

Open bramski opened this issue 4 years ago • 3 comments

Repro steps: Publish my package to yalc like: yalc publish then install it in the needed other repo like... yalc add my-package

Inspect /node_modules/my-package It includes it's own node_modules folder e.g....

/node_modules/my-package
             /build
             /node_modules

This is problematic and breaking my build. In this case for our project all the dependencies needed for my-package are peerDependencies and including node_modules is causing react-intl to be duplicated which breaks the interoperability of the context provider.

bramski avatar Sep 22 '21 20:09 bramski

i dont have node_modules exported. Are you explicitely export it via files directive in package.json?

logemann avatar Oct 18 '21 12:10 logemann

Probably your package manager while install puts this folder there.

wclr avatar Oct 18 '21 13:10 wclr

Work well on my project too without node_modules @bramski Would be nice if you can setup sandbox of your project, I'm curious why node_modules is installed

tranquan avatar Oct 30 '21 19:10 tranquan