vue3-google-signin icon indicating copy to clipboard operation
vue3-google-signin copied to clipboard

FedCM becomes mandatory

Open agracia-foticos opened this issue 1 year ago • 24 comments

Describe the bug GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://vue3-google-signin.wavezync.com/guide/one-tap-login.html
  2. Sign in with one tap image
  3. In console there is this error: [GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

Reproducible Example If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

agracia-foticos avatar Apr 29 '24 09:04 agracia-foticos

Hey thanks for bringing attention to this

kasvith avatar Apr 29 '24 09:04 kasvith

Hey thanks for bringing attention to this

Any idea of ​​the error? Can I bypass the error somehow?

agracia-foticos avatar Apr 29 '24 09:04 agracia-foticos

im checking the docs and trying to fix this in a new release

kasvith avatar Apr 29 '24 09:04 kasvith

it will be backward compatible for you

kasvith avatar Apr 29 '24 09:04 kasvith

im checking the docs and trying to fix this in a new release

THANKS A LOT!!!

agracia-foticos avatar Apr 29 '24 09:04 agracia-foticos

as i checked we arent even using there methods, but still gets the warning. i will dig into this

kasvith avatar Apr 29 '24 09:04 kasvith

as i checked we arent even using there methods, but still gets the warning. i will dig into this

Do you know approximately what deadlines you have for uploading the new version with the patch applied?

agracia-foticos avatar Apr 29 '24 10:04 agracia-foticos

I cant provide a deadline sadly

kasvith avatar Apr 29 '24 10:04 kasvith

I cant provide a deadline sadly

We hope for news soon. If you need any other information, do not hesitate to ask.

agracia-foticos avatar Apr 29 '24 10:04 agracia-foticos

i still could not figure out this, we are not using any methods described by FedCM :(

kasvith avatar May 07 '24 08:05 kasvith

i still could not figure out this, we are not using any methods described by FedCM :(

Perhaps they enforce it automatically in supported browsers.

infinnie avatar May 31 '24 11:05 infinnie

Has it been fixed?

jsony avatar Jun 25 '24 09:06 jsony

Hi all, unfortunately the fix is unclear for me. this library does not use anything which is not working with FedCM as i looked into

kasvith avatar Jun 25 '24 09:06 kasvith

Any advance??

image

In your web also fails the login! :(

do you need another reproduction?

agracia-foticos avatar Jul 10 '24 05:07 agracia-foticos

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

kasvith avatar Jul 10 '24 08:07 kasvith

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

image

versión of google chrome Versión 126.0.6478.126 (Build oficial) (64 bits)

image

agracia-foticos avatar Jul 10 '24 09:07 agracia-foticos

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

kasvith avatar Jul 22 '24 06:07 kasvith

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

Do you need anymore?

agracia-foticos avatar Jul 22 '24 06:07 agracia-foticos

Its bit confusing, if we at least use these deprecated methods its easier to remove them. but we dont use them at all. im not sure whether this is a false indicator

kasvith avatar Jul 22 '24 06:07 kasvith

@kasvith - these methods are defined in the PromptMomentNotification interface in interfaces/accounts.ts. According to the FedCM migration docs it looks like they should be removed altogether?

JasonMSims avatar Aug 19 '24 15:08 JasonMSims

@JasonMSims even they are defined they aren't being used anywhere

its mostly for the typescript stuff

i removed them locally and tried also, but same results

kasvith avatar Aug 19 '24 15:08 kasvith

Any advance???

agracia-foticos avatar Oct 16 '24 10:10 agracia-foticos

In https://vue3-google-signin.wavezync.com/guide/one-tap-login.html i try to login with one tap and this is the error

image

The fetch of the id assertion endpoint resulted in a network error: ERR_FAILED one-tap-login.html:1 The provider's token fetch resulted in an error response code. client:71 [GSI_LOGGER]: FedCM get() rejects with IdentityCredentialError: Error retrieving a token.

agracia-foticos avatar Oct 16 '24 10:10 agracia-foticos

hi, im planning to do a major upgrade with new vite and add FedCM support to project

kasvith avatar Oct 30 '24 19:10 kasvith