vue3-google-signin icon indicating copy to clipboard operation
vue3-google-signin copied to clipboard

feat: dynamic clientId Initialization

Open zuhno opened this issue 1 year ago • 3 comments

Hi :)

  1. Added folders for methods, constants, and states (for global ref) under src, and restructured the folder architecture considering scalability for future method development.
  2. Introduced a new method named setGoogleClientId, which operates by changing the global ref value.
  3. The clientId can be initialized in the following ways:
  • Statically during middleware installation.
  • Dynamically in any component.
  • Initially set and later updated dynamically.
  1. Fixed an issue where the style height value was not being applied to the element before the renderButton of GoogleSignInButton is called.
  2. Updated the documentation, including a caution block in the section about initializing nuxt-vue3-google-signin.

I am very happy to contribute to this project. Please let me know if there are any suggestions for improvements in the folder structure or functionality.

zuhno avatar Jan 02 '24 15:01 zuhno

Thanks @zuhno

this is a brilliant work, and im really happy about this PR 💪 i will review the code and let you know my thoughts :)

it looks really good as i checked on surface

kasvith avatar Jan 02 '24 16:01 kasvith

@kasvith Please let me know if there are any parts that need to be revised.

zuhno avatar Apr 26 '24 04:04 zuhno

Sure, i didnt have much time lately to focus on the project

kasvith avatar Jun 17 '24 04:06 kasvith