container-image-csi-driver icon indicating copy to clipboard operation
container-image-csi-driver copied to clipboard

New logo is not getting loaded on the README

Open mugdha-adhav opened this issue 1 year ago • 4 comments

We recently added a logo for our repository in https://github.com/warm-metal/container-image-csi-driver/pull/80.

After we merged the PR, the logo is not loading for me on the README.

Screenshot 2024-02-15 at 8 27 07 PM

mugdha-adhav avatar Feb 15 '24 14:02 mugdha-adhav

Ah, I noticed I can see the logo when I'm not on dark mode on my system.

image

Dark mode causes the logo to not show up.

mbtamuli avatar Feb 15 '24 16:02 mbtamuli

I found the issue - https://github.com/warm-metal/container-image-csi-driver/blob/3d36010ac57a9324f23d96ce22c7355a2878ef42/README.md?plain=1#L4

The dark mode calls a file that doesn't exist.

mbtamuli avatar Feb 15 '24 16:02 mbtamuli

The logo would look something like this after getting rendered in the dark mode -

Screenshot 2024-02-16 at 3 19 31 AM

Any suggestions on do we want a different colour scheme in the logo for dark mode?

mugdha-adhav avatar Feb 15 '24 21:02 mugdha-adhav

do we want a different colour scheme in the logo for dark mode?

Maybe we can move this to a discussion? So we keep this issue crisp and ready for anyone getting started on the repository as a good-first-issue.

mbtamuli avatar Feb 16 '24 11:02 mbtamuli

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

github-actions[bot] avatar Jun 01 '24 00:06 github-actions[bot]