security-vocab icon indicating copy to clipboard operation
security-vocab copied to clipboard

Published 20 hours ago • verified publisher icon w3c-ccg

Update CI to prevent lint, test and build failures from being merged

Open OR13 opened this issue 5 years ago • 4 comments

We should have CI/CD and branch protection on for repo's that impact security.

It should not be possible to merge a PR that fails branch protection rules (approved by code owner + no lint or build errors).

OR13 avatar Jan 20 '20 18:01 OR13

Generally supportive, now all we need is someone to do the work. :)

msporny avatar Jan 20 '20 19:01 msporny

It should not be possible to merge a PR that fails branch protection rules (approved by code owner).

I've just enabled this.

Still need to enable merge prevention on build/lint errors.

msporny avatar Jan 20 '20 19:01 msporny

Implemented CI, there are still no tests and no lint.

OR13 avatar May 03 '20 17:05 OR13

There are now lint settings... In a way the did core registries tests also use these... its a bit odd to think of testing vocabulary....the main thing to test would be integrity checks IMO.

OR13 avatar May 04 '20 13:05 OR13