puppet-windows_firewall icon indicating copy to clipboard operation
puppet-windows_firewall copied to clipboard

Puppet Modules should enforce a desired state

Open Romiko opened this issue 7 years ago • 5 comments

Preconditions. Firewall module used to set a few ports e.g. RDP, Web etc

If a user manually added a new port to the Firewall in Windows. This module has no functionality to remove rules that are not defined, which defeats the purpose of leveraging puppet.

A puppet module should allow you to configure a service and any manual changes to that service are deleted when the puppet agent runs.

I feel this module needs some important functionality to be enterprise grade.

  1. Purge firewall rules that are not defined in puppet
  2. Allow you to specify exceptions for Profile - Public, Private and Domain
  3. Keep Established connections during the puppet agent run

What are your thoughts on this?

Romiko avatar Jun 04 '18 05:06 Romiko

Just noticed the same thing is true for the enabled / disabled state.

A user can go in and manually disable a rule and this module doesn't go an re-enable it based on the desired state in the Puppet catalog.

nmaludy avatar Aug 13 '19 17:08 nmaludy

This might be a duplicate of #23

nmaludy avatar Aug 13 '19 17:08 nmaludy

Hoping this gets addressed soon...managing firewall exceptions through this is borderline useless without enforcing the state. The only option I see around this issue currently is to duplicate the rule to a new name, and mark the original one as 'ensure => absent' and wait for all nodes to delete it.

mike406 avatar Apr 14 '21 13:04 mike406

@bishopbm1 do you have any time to help?

nmaludy avatar Apr 14 '21 13:04 nmaludy

This is something that has been on my radar for a while now. Unfortunately I don't have immediate time to work on it but hoping to have some of that time freed up by the end of the month where I can dedicate some time to this.

bishopbm1 avatar Apr 14 '21 15:04 bishopbm1