puppet-php

puppet-php copied to clipboard

Hi @edestecd, thanks for the PR. Can you provide acceptance tests that use different values for the parameter?

Nov 02 '18 13:11 bastelfreak

@bastelfreak tests added

Nov 06 '18 18:11 edestecd

Hi @edestecd you added unit tests, and you can let the file in the PR. This is interesting to have more tests. But @bastelfreak talk about acceptance tests not unit tests. If you need some guidance, fell free to join us on slack or IRC #Voxpupuli for interactive talks.

Nov 06 '18 19:11 Dan33l

@Dan33l I didn't see any acceptance tests for debian or ubuntu for example. SO i don't know how you usually write them. I'll try and have a look at some others.

Nov 06 '18 19:11 edestecd

In this module, you can find :

• the helper_acceptance. The role of the helper is to prepare system under tests (SUT) to be ready for being able to receive tests.
• 2 spec files making tests php56_spec.rb and php_spec.rb
• the file .travis.yml that permit to run tests defined by previous items. All lines with BEAKER are acceptance tests executed for each PR.

So tests about all supported OSes should be present. For instance this line launch tests under CentOS7 with puppet5

You can run tests locally on you work station. The CONTRIBUTING.md file gives some guidance about this in the section intergation tests

You can find also some guidance on serverspec.org about how to tests items that are expected to be present or absent on the SUT.

Nov 06 '18 20:11 Dan33l

Dear @edestecd, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Jun 18 '22 13:06 vox-pupuli-tasks[bot]