puppet-corosync

puppet-corosync copied to clipboard

I didn't spot an open PR on this, but there is open issue #485

It seems that the release of pacemaker 2.0.3 (in RHEL8) removes the option of supplying the superfluous score parameter.

Here is the documentation for pacemaker 2.0 which makes no mention of a score property: https://clusterlabs.org/pacemaker/doc/en-US/Pacemaker/2.0/html/Pacemaker_Explained/s-resource-ordering.html

Pull Request (PR) description

Removes the score parameter from cs_order type as it is no longer valid and causes errors.

This Pull Request (PR) fixes the following issues

Fixes #485

Dear @rstuart-indue, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

I tried to rebase this on my own and failed :(

Is there anything still outstanding on this PR? is there a reason it hasn't been merged?

@shaneshort it has some merge conflicts and the tests don't pass, we cannot merge it this way. I don't know how to fix them :(

Dear @rstuart-indue, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

score is still a valid optional parameter according to the order constraint schema: https://github.com/ClusterLabs/pacemaker/blob/master/xml/constraints-3.5.rng#L155-L160