rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Updating `volta pin` to support a `--default` flag

Open charlespierce opened this issue 1 year ago • 5 comments

Proposal for updating volta pin to add a --default flag that replaces the need for volta install, combining all of the pin operations into a single volta pin command.

Rendered

charlespierce avatar Feb 22 '24 19:02 charlespierce

Suggestion from the main Volta repo: Having volta use be an alias for this combined command would be useful for people switching from / used to nvm, since nvm use is used to change Node versions. It's not exactly the same semantics, so we might want to consider how different it is and how difficult it will be to transition, but I think if we combine the commands it would be a good time to look at making use another alias for the same command.

charlespierce avatar Jul 10 '24 03:07 charlespierce

I definitely don’t have an objection to use, @charlespierce; do you remember why we didn’t choose that in the first place? (I believe that decision preceded my working on the project, but it has been a minute, so one way or another I simply do not recall.)

chriskrycho avatar Sep 10 '24 13:09 chriskrycho

Updated to a new proposal of continuing to use volta pin with an explicit flag (currently --default) for pinning the default version.

charlespierce avatar Oct 03 '24 16:10 charlespierce

@charlespierce - I really like this last round of updates, definitely makes more sense to me this way.

rwjblue avatar Oct 03 '24 16:10 rwjblue

I definitely don’t have an objection to use, @charlespierce; do you remember why we didn’t choose that in the first place? (I believe that decision preceded my working on the project, but it has been a minute, so one way or another I simply do not recall.)

I don't have a deep recollection, but I think we actually did have notion use as a command very early on (that's how long ago it was, prior to the rename). I can't find the git history of why we removed it, likely because it caused more confusion due to the differences with nvm

charlespierce avatar Oct 03 '24 17:10 charlespierce