wasm-workers-server icon indicating copy to clipboard operation
wasm-workers-server copied to clipboard

Switch to rustls to avoid compiling OpenSSL

Open Angelmmiguel opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe.

Currently, the project relies on OpenSSL to perform https requests to pull the different runtimes. We are using the reqwest crate for it. When compiling the project to Linux with the musl toolchain, we started facing errors due to missing dependencies.

To fix it, we configured the openssl dependency to build the project using the vendored feature. We only applied this to the musl targets:

https://github.com/vmware-labs/wasm-workers-server/blob/feedff9668bd35309033f7b484d2777c1820f088/Cargo.toml#L39-L43

We want to avoid compiling this dependency as it causes other issues in the past.

Describe the solution you'd like

The goal is to use the rustls crate. We can configure reqwest to use it via features. However, we cannot do it yet due to an issue with the Windows aarch64 target in the ring dependency. The problem is fix, although the new release is not public yet.

You can track the current status on: https://github.com/briansmith/ring/issues/1551

Describe alternatives you've considered

No response

Additional context

No response

Angelmmiguel avatar May 25 '23 10:05 Angelmmiguel

The ring 0.17.0 release is already out! I will open a PR to close this.

Angelmmiguel avatar Oct 04 '23 12:10 Angelmmiguel

I'm now waiting for rustls to update ring to the latest version.

Angelmmiguel avatar Oct 04 '23 12:10 Angelmmiguel

The changes in rustls are merged. Now, we are waiting for the backport to the 0.21.X version. Then, we will be able to switch as 0.22 will take more time.

Angelmmiguel avatar Oct 16 '23 06:10 Angelmmiguel

Blocked now by #256

Angelmmiguel avatar Nov 24 '23 12:11 Angelmmiguel