distribution-tooling-for-helm icon indicating copy to clipboard operation
distribution-tooling-for-helm copied to clipboard

Published 20 hours ago • verified publisher icon vmware-labs

Remove non-required `ClientOptResolver` option usage

Open antgamdia opened this issue 1 year ago • 1 comments

In Kubeapps, we needed to add a new ClientOptResolveroption in the Helm project (context here). However, this is mostly for tests and other non-typical use-cases. The current NewClient function in Helm is setting the required options in the autorizer, so there is no need to manually set the resolver (see the code)

This PR is mainly remove those redundant piece of code, so that ClientOptResolver is not used anymore.

The rationale behind the change is in https://github.com/helm/helm/pull/12310#discussion_r1501065719. In short, this is blocking a potential upgrade from ORAS v1 to v2 at Helm's side.

antgamdia avatar Feb 26 '24 11:02 antgamdia

ping @juamedgod / @alemorcuq :P

Edit: as per an offline sync, they will go ahead with the change if Helm decides to effectively migrate to ORAS v2.

antgamdia avatar Mar 05 '24 11:03 antgamdia