v
v copied to clipboard
vlang
os: fix `os.join_path('/', 'file.txt')` and `os.join_path_single('/', 'file.txt')` (fix #20231)
@spytheman what are you doing? are you stealing my PR? Let's not waste double efforts into solving the SAME ISSUE on multiple fronts there are 850+ issues to work on why not work together?
@spytheman what are you doing? are you stealing my PR? Let's not waste double efforts into solving the SAME ISSUE on multiple fronts there are 850+ issues to work on why not work together?
I am fixing it in a different way, that will require way less edits and review changes.
I am sorry, but os and join_path especially, is not the place for learning about V, and I am not in the mood of breaking bootstrapping and then fixing it slowly today.
Once it passes the CI, I can push to your PR, and then you will get the credit, when it is merged. I do not care about that at all. I simply do not want problems with the bootstrap and I have enough experience to know that changes in that particular place are tricky.
@hholst80, the CI passed for this PR, and imho it will be a bit less breaking, while ensuring the future stability of the behavior of os.join_path and os.join_path_single (which are now more unified in their output, and better tested).
Do you want me to push the changes here to your PR, so that I can merge them there?