v icon indicating copy to clipboard operation
v copied to clipboard

Published 20 hours ago • verified publisher icon vlang

ci: add windows and macos jobs for checking the wasm backend too

Open spytheman opened this issue 2 years ago • 2 comments
trafficstars

  • ci: test the wasm backend on macos too
  • use -lc++ on macos
  • do not pass --Wl,-rpath,/opt/homebrew/lib on macos
  • fix -Wl,-rpath on macos

spytheman avatar Mar 01 '23 13:03 spytheman

  • do not pass --Wl,-rpath,/opt/homebrew/lib on macos Do you mean that:

#flag darwin -lc++ -Wl,-rpath,"@executable_path/../../../thirdparty/binaryen/lib" --Wl,-rpath,/opt/homebrew/lib do not pass the ci test ?

Don't adding --Wl,-rpath,/opt/homebrew/lib allows users to have homebrew install of binaryen working without the vsh script? I thought It was working for me without installing binaryen from the vsh script but with brew install binaryen.

rcqls avatar Mar 01 '23 14:03 rcqls

#flag darwin -lc++ -Wl,-rpath,"@executable_path/../../../thirdparty/binaryen/lib" --Wl,-rpath,/opt/homebrew/lib do not pass the ci test ?

It did not, see https://github.com/vlang/v/actions/runs/4305124588/jobs/7507121218 for 871c557 . I'll try again later locally, for now I am focusing on fixing the windows job first.

spytheman avatar Mar 01 '23 15:03 spytheman