Access-Control-Allow-Origin icon indicating copy to clipboard operation
Access-Control-Allow-Origin copied to clipboard

Fixes #36

Open seedofjoy opened this issue 9 years ago • 5 comments

Fix resetting settings to default when you upgrade your browser.

seedofjoy avatar Feb 23 '16 18:02 seedofjoy

Those defaults might be set for a reason, maybe something like the below would be safer. This is completely untested!

chrome.storage.local.get('active', function(value) {
  if (!chrome.runtime.lastError) // storage already set
    return;
  chrome.storage.local.set({
    active: false,
    urls: ["<all_urls>"],
    exposedHeaders: ''
  });
});

jdart avatar Aug 17 '16 14:08 jdart

@vitvad How does my above comment look to you?

jdart avatar Aug 17 '16 14:08 jdart

resolves #36

jdart avatar Aug 17 '16 14:08 jdart

@jdart my code doesn't broke anything because of this: chrome.storage.local.get({'active': false, 'urls': ["<all_urls>"], 'exposedHeaders': ''}, function(result) { - this is single place where settings are used (with default settings)

seedofjoy avatar Aug 17 '16 16:08 seedofjoy

Oh cool, well, I'd love to see this merged!

jdart avatar Aug 17 '16 18:08 jdart