vite icon indicating copy to clipboard operation
vite copied to clipboard

fix: support process each out dir when there are two or more

Open qmhc opened this issue 3 years ago • 2 comments

Description

prepareOutDir only process the build.outDir, and the actions include empty dir and copy public dir for those defined in output.dir will be ignored.

Additional context

I notice that it will build output options twice if config.build.watch defined, so I promote the process to above.


What is the purpose of this pull request?

  • [x] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Read the Pull Request Guidelines and follow the Commit Convention.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

qmhc avatar Aug 19 '22 07:08 qmhc

I found a problem about the split regexp, fixed it.

The original regexp will be incorrect when the skip paths includes more than two levels of nesting.

empty(dir, ['a/b/c', 'a/b/d'])

qmhc avatar Aug 23 '22 00:08 qmhc

@qmhc we discussed this PR in today's team meeting and we think we can move forward with it. Before merging we should resolve the open discussions. We decided that the public files should be copied multiple times, to each output.dir.

patak-dev avatar Sep 09 '22 14:09 patak-dev