sweet-modal-vue icon indicating copy to clipboard operation
sweet-modal-vue copied to clipboard

Add timeout to close modals automatically

Open Munk91 opened this issue 7 years ago • 3 comments

Hello.

I needed to set a custom timeout to close modals automatically, so I added that. Hope you like it 🛩

Tell me if there is something I need to do, this is my first PR to this project.

Munk91 avatar Nov 06 '17 22:11 Munk91

Hi, thanks for your contribution! 🙏 There are two missing things, though:

  1. The parameter "timeout" hasn't been given to the function signature.
  2. The project has to be built and the resulting files be committed, too.

bluefirex avatar Nov 09 '17 13:11 bluefirex

@bluefirex Hello. I tried to build but got some issues - it seems like there are some problems building sourcemaps atm.

It looks like the same as #42

I disabled babili-webpack-plugin in webpack config, so the build could go through.

If you find it neccesary to include sourcemaps - can you try and run it with your own config?

There are some known issues on the source map thingy, check out:

  • https://github.com/mozilla/source-map/issues/304
  • https://github.com/webpack/webpack-sources/issues/28

Munk91 avatar Nov 13 '17 20:11 Munk91

@bluefirex Status on review? :smiley:

Munk91 avatar Nov 23 '17 07:11 Munk91