kvm-guest-drivers-windows icon indicating copy to clipboard operation
kvm-guest-drivers-windows copied to clipboard

Published 20 hours ago • verified publisher icon virtio-win

viostor: It seems that RhelScsiVerify has an improperly handled boundary condition.

Open zjmletang opened this issue 1 year ago • 3 comments

Describe the bug In the RhelScsiVerify function, I understand that the case where lba + blocks == adaptExt->lastLBA should be a normal SRB. As shown in the figure below. If I am mistaken, please point it out to me.

image

zjmletang avatar May 09 '24 05:05 zjmletang

Right, we probably missed this case when applied https://github.com/virtio-win/kvm-guest-drivers-windows/commit/67f64d01967769d4b9673e4c1bd08fab184469d7

Thank you for spotting it out. The fix is welcome. Vadim.

vrozenfe avatar May 09 '24 10:05 vrozenfe

Other location I found it seems to be correct: https://github.com/virtio-win/kvm-guest-drivers-windows/blob/657ad7efb539dd186cec1fd33cf31ba710f5dfb1/viostor/virtio_stor.c#L1333

MaxXor avatar May 09 '24 11:05 MaxXor

Right, we probably missed this case when applied 67f64d0

Thank you for spotting it out. The fix is welcome. Vadim. @vrozenfe ok, I submit a patch to fix it JianMing

zjmletang avatar May 10 '24 06:05 zjmletang

Quess this can be closed with https://github.com/virtio-win/kvm-guest-drivers-windows/commit/4a388316733fd1e077262d5dfb534642f5abc5fb

jumbi77 avatar Jun 12 '24 21:06 jumbi77

yes, it can be closed

zjmletang avatar Jun 19 '24 04:06 zjmletang