videojs-contrib-dash

videojs-contrib-dash copied to clipboard

Because of this line of code in dash.js, captions don't render on IE11/Edge.

Normally VTTCue wouldn't be loaded on IE/Edge in dash.js, but since it's pulled in from video.js, dash.js uses new VTTCue to make the cues. This is incompatible with IE/Edge's TextTrack.addCue, as it requires a TextTrackCue as the argument, and will reject a VTTCue.

Thoughts on the best way to solve this?

Hmm. I somehow missed the extensive discussion on #135 about this very issue. It sounds like it was resolved, though :confused:

I've got a resolution for this in #192, looks like video.js/vttjs's VTTCue shim is conflicting with what dash.js expects

Hmm, I tried the patch, doesn't seem to work. I still get the Invalid argument error. Which dash.js version are you using, 2.5.0 I guess?

My mistake, the PR missing a commit where I clear window.VTTCue if it's not native

Still not working for me. I'm just serving up the index.html in the repo.

There's still a VTTCue attached to the window

Right I still need to push the commit, currently on the way home

Oh, sorry, I misunderstood.